Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The workflow has safe-output configuration gaps, and several documentation links and commands are incorrect.
Get a fresh assessment by requesting another Copilot review.
Review tier: Balanced
Findings: 2
Open (7)
What changed in this PR
Adds automated rust-analyzer updates for the Rust extractor.
Changes:
- Adds a deterministic updater script and instructions.
- Adds an agentic workflow and generated lock file.
- Marks compiled workflows as generated.
| File | Description |
|---|---|
rust/updating-rust-analyzer.md |
Documents the update process. |
rust/scripts/update_rust_analyzer.py |
Automates dependency, toolchain, codegen, and build steps. |
rust/README.md |
Links to the extracted instructions. |
.github/workflows/update-rust-analyzer.md |
Defines the agentic workflow. |
.github/workflows/update-rust-analyzer.lock.yml |
Contains the compiled workflow. |
.gitattributes |
Marks workflow lock files as generated. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
andersfugmann
approved these changes
Sep 18, 2026
Comment on lines
+76
to
+83
| rust_manifest = next( | ||
| manifest | ||
| for manifest in reversed( | ||
| fetch("https://static.rust-lang.org/manifests.txt").decode().splitlines() | ||
| ) | ||
| if manifest.endswith("/channel-rust-stable.toml") | ||
| and manifest.split("/")[2] <= rust_analyzer_release | ||
| ) |
Contributor
There was a problem hiding this comment.
Slightly hard to read.
If I read is correctly, it fetches 'https://static.rust-lang.org/manifests.txt', filters so it only contains entries ending on '/channel-rust-stable.toml' and then picks any version date that is lower equal to when the rust analyser was released.
| return manifest["pkg"]["rust"]["version"].split()[0] | ||
|
|
||
|
|
||
| def update_fixed_rust_toolchain(version: str) -> None: |
Contributor
There was a problem hiding this comment.
May I suggest update_hardcoded_toolchain_versions for clarity.
| raise SystemExit(error.returncode) from None | ||
|
|
||
|
|
||
| def get_rust_analyzer_version() -> str: |
Contributor
There was a problem hiding this comment.
Please rename to get_min_rust_analyzer_version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds automation for updating rust-analyzer in the Rust extractor.
We:
Guide to reviewer: