feat(remix): Upload source maps from the Vite plugin - #24463
Merged
chargome merged 8 commits intoSep 18, 2026
Merged
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
chargome
added this pull request to stack #24474
September 17, 2026 13:51
chargome
force-pushed
the
chargome/feat/remix-vite-plugin-sourcemaps-upload
branch
from
September 17, 2026 13:51
30cf8b7 to
da4b0b8
Compare
Member
Author
|
bugbot run |
1 similar comment
Member
Author
|
bugbot run |
chargome
force-pushed
the
chargome/feat/remix-vite-plugin-sourcemaps-upload
branch
from
September 17, 2026 14:09
f1db477 to
a32a5d0
Compare
Member
Author
|
bugbot run |
Member
Author
|
bugbot run |
Member
Author
|
bugbot run |
chargome
force-pushed
the
chargome/feat/remix-vite-plugin-sourcemaps-upload
branch
from
September 17, 2026 16:24
2ea4d63 to
948599d
Compare
Member
Author
|
bugbot run |
chargome
force-pushed
the
chargome/feat/remix-vite-plugin-sourcemaps-upload
branch
from
September 18, 2026 08:00
948599d to
9e2f00c
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 4 total unresolved issues (including 3 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9e2f00c. Configure here.
chargome
marked this pull request as ready for review
September 18, 2026 11:25
chargome
requested review from
mydea,
nicohrubec and
s1gr1d
and removed request for
a team and
mydea
September 18, 2026 11:25
s1gr1d
approved these changes
Sep 18, 2026
| // Uploading from the dev server would create a new set of artifacts on every restart. | ||
| if (process.env.NODE_ENV === 'development' || options.sourcemaps?.disable === true) { | ||
| return plugins; | ||
| } |
Member
There was a problem hiding this comment.
If someone sets disable: true now, it drops more than source maps now. If people any other options, those are not forwarded to the plugins anymore.
Or is this intentional?
Member
Author
There was a problem hiding this comment.
Nice catch that is an oversight, this is handled in the plugin anyways. I'll remove the gate here
JPeer264
approved these changes
Sep 18, 2026
`sentryRemixVitePlugin` now injects debug IDs and uploads source maps as part of the build, so Vite-based Remix apps no longer need the `sentry-upload-sourcemaps` script. The deletion default is scoped to `./build/**/*.map` rather than `./**/*.map`, because the bundler plugin globs it without ignoring `node_modules` and deletes with `force: true`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`sourceMaps.ts` imports `@sentry/bundler-plugins/vite`, which was not declared in `package.json` - published installs could not resolve it. Vite passes the already-merged config to every `config` hook, so the files-to-delete plugin has to run before `makeEnableSourceMapsPlugin` sets `build.sourcemap`; otherwise it treats the setting as user-owned and leaves the generated source maps on disk. Also returns only the changed key from the `config` hook, since Vite concatenates arrays when merging the returned value. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`sourcemaps.disable: 'disable-upload'` injects debug IDs but leaves the upload to the user. The bundler plugin deletes `filesToDeleteAfterUpload` in a `finally` block even when it skipped uploading, so defaulting the deletion removed the very maps that still had to be uploaded by hand. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
A hardcoded `./build/**/*.map` left a custom Remix `buildDirectory` untouched, silently shipping its source maps. Deriving the glob from `build.outDir` also scopes Remix's client and SSR passes to the output each one actually emitted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Vite resolves `build.outDir` to an absolute path, so prefixing it with `./` produced `.//abs/path/**/*.map`, which matches nothing and left the generated source maps in the production output. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`glob` reads a backslash as an escape, so a Windows `outDir` produced a pattern that matched nothing and left the generated source maps on disk. Both path flavours are now checked for absoluteness, since `path.isAbsolute` only recognises the host platform's form. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`sourcemaps.disable: true` skipped the whole bundler plugin, which also applies bundle size optimizations, module metadata, the application key and release management. The plugin already declines the upload on its own, so only the source map setting plugin needs gating. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
chargome
force-pushed
the
chargome/feat/remix-vite-plugin-sourcemaps-upload
branch
from
September 18, 2026 12:08
c46a741 to
7f9cd08
Compare
chargome
deleted the
chargome/feat/remix-vite-plugin-sourcemaps-upload
branch
September 18, 2026 13:06
chargome
added a commit
that referenced
this pull request
Sep 18, 2026
Asserts each client chunk carries exactly one debug ID and that the shipped IDs match the uploaded artifact bundles. Stacked on #24463. --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentryRemixVitePluginnow injects debug IDs and uploads source maps as part of the build. Options widen toBuildTimeOptionsBase; opt out withsourcemaps.disable.Deletion defaults to
./build/**/*.maprather than./**/*.map, which the bundler plugin globs without ignoringnode_modulesbefore deleting withforce: true.