Conversation
Fixes getsentry#24284. Co-Authored-By: GPT-6 <codex@openai.com>
Co-Authored-By: GPT-6 <codex@openai.com>
Author
ihsraham
marked this pull request as ready for review
September 15, 2026 04:01
ihsraham
requested review from
mydea and
s1gr1d
and removed request for
a team
September 15, 2026 04:01
s1gr1d
reviewed
Sep 18, 2026
s1gr1d
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution! I added a few comments
| attributes: { | ||
| [SENTRY_SEGMENT_NAME_SOURCE]: routeInfo ? 'route' : 'url', | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.pageload.ember', | ||
| ...(routeInfo ? { [ROUTER_NAVIGATION_ROUTE_ID]: `route:${routeInfo.name}` } : {}), |
Member
There was a problem hiding this comment.
The attribute is defined as only assigned by the framework (see here). We should not add another prefix (route:) here but just the plain route name.
| attributes: { | ||
| [SENTRY_SEGMENT_NAME_SOURCE]: 'route', | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.ember', | ||
| ...(toRoute !== undefined ? { [ROUTER_NAVIGATION_ROUTE_ID]: `route:${toRoute}` } : {}), |
Member
There was a problem hiding this comment.
Instead of !== undefined you could check with && as we probably don't want to care about empty strings either.
| // Only the `ember-strict-resolver (streamed)` variant builds the app with `traceLifecycle: 'stream'`. | ||
| test.skip(process.env.E2E_TEST_TRACE_LIFECYCLE !== 'stream', 'requires the app built with span streaming'); | ||
|
|
||
| test('preserves the route name on a streamed pageload', async ({ page }) => { |
Member
There was a problem hiding this comment.
The test name(s) should be rather something like "adds the route ID to a streamed pageload"
Contributor
|
👋 @mydea — Please review this PR when you get a chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ember pageload and navigation spans lack the route ID used to infer their descriptions. Add
router.navigation.route.idwhen the route becomes known, using the existingroute:prefix. Omit it when the route is unknown so a later update preserves caller-provided metadata.Fixes #24284.