Close HostnameCache#executorService on SentryClient#close. - #1757
Merged
Merged
Conversation
maciejwalkowiak
marked this pull request as ready for review
October 8, 2021 12:06
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
October 8, 2021 12:06
Codecov Report
@@ Coverage Diff @@
## main #1757 +/- ##
============================================
- Coverage 75.34% 75.31% -0.04%
- Complexity 2158 2165 +7
============================================
Files 215 215
Lines 7699 7718 +19
Branches 820 822 +2
============================================
+ Hits 5801 5813 +12
- Misses 1502 1507 +5
- Partials 396 398 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1756.
📜 Description
Close
HostnameCache#executorServiceonSentryClient#close.💡 Motivation and Context
Fixes #1756.
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps