Add Suave server integration package by Copilot · Pull Request #567 · fsprojects/FSharp.Data.GraphQL

Copilot · 2026-05-17T14:19:53Z

This adds an official Suave integration package for FSharp.Data.GraphQL, following the existing Giraffe/Oxpecker shape. The new package exposes GraphQL as a Suave WebPart so it can be embedded directly into larger Suave applications.

New Suave integration package
- adds FSharp.Data.GraphQL.Server.Suave
- exposes:
  - HttpHandlers.graphQL
  - HttpHandlers.setRequestType
- supports the existing server behaviors needed for:
  - GET introspection requests
  - POST JSON GraphQL requests
  - multipart upload requests
Request handling model
- maps Suave request data into the existing GraphQL execution flow instead of introducing a parallel server path
- includes a Suave-specific IInputExecutionContext implementation for file uploads
- preserves the existing Request-Type response header convention used by the current integrations
Packaging and build wiring
- adds the new project to solution files
- includes the package in shared dependency management
- wires pack/push targets into the build script alongside the other server integration packages
Focused coverage
- adds targeted tests for the Suave handler covering:
  - JSON query execution
  - GET introspection
  - multipart file upload execution

Example usage:

open Suave
open Suave.Operators
open FSharp.Data.GraphQL.Server.Suave

let app =
    HttpHandlers.setRequestType
    >=> HttpHandlers.graphQL Schema.executor rootFactory

njlr · 2026-05-17T14:53:52Z

@copilot Does this support websocket aspects of GraphQL spec?

xperiandri · 2026-05-17T18:07:20Z

@copilot Does this support websocket aspects of GraphQL spec?

@copilot answer, please.
Check the WebSockets implementation in ASP.NET Core project and can it be used or is it referenced by Suave support implementation and give an answer

Copilot · 2026-05-17T18:08:48Z

@copilot Does this support websocket aspects of GraphQL spec?

@copilot answer, please.
...

Checked this in the current implementation at 46c8871: no, the Suave package does not support the WebSocket/GraphQL-over-WebSocket part right now.

What exists today in FSharp.Data.GraphQL.Server.Suave is only HTTP handling for GET/POST in src/FSharp.Data.GraphQL.Server.Suave/HttpHandlers.fs. There is no WebSocket route, no socket accept flow, and no reference to the ASP.NET Core WebSocket middleware.

The WebSocket implementation lives in src/FSharp.Data.GraphQL.Server.AspNetCore/GraphQLWebsocketMiddleware.fs and is wired through UseWebSocketsForGraphQL in src/FSharp.Data.GraphQL.Server.AspNetCore/ServiceCollectionExtensions.fs. The Suave project does not reference FSharp.Data.GraphQL.Server.AspNetCore, so that middleware is not reused by the Suave integration.

So the short answer is: HTTP GraphQL is supported in Suave, WebSocket GraphQL is not. Reusing the ASP.NET Core implementation as-is would not work directly; it would need either a Suave-specific WebSocket adapter or a refactor that extracts the transport-agnostic parts into shared code.

…ory` and remove external server orchestration from build (#564) Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>

…compile time (#569) Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>

Signed-off-by: dependabot[bot] <support@github.com>

…, and add PR preview publishing (#570) Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>

Added MSBuild target to ensure DesignTime DLL is included in NuGet package, working around F# SDK limitations with ProjectReference-based providers. Removed obsolete target for cleaning NuGet pack input and updated conditions for consistency.

… to `3.53.3` (#588) Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>

* Refactored `ObjectListFilter`: modularized, added type coercion - Moved filter operators and LINQ logic to ObjectListFilterModule.fs - Added `TypeCoercion.fs` for automatic filter value coercion (`Guid`, `DateTime`, F# DUs, etc.) - Introduced `FilterValueCoercer` and extended `ObjectListFilterLinqOptions` for custom coercion - Centralized filter suffix constants in `FilterSuffixConstants.fs` - Updated `SchemaDefinitions.fs` to use new suffix constants - Added `vtryFind` and `vtryPick` utilities for arrays/lists in `Extensions.fs` - Improved code style, documentation, and function signatures * Refactor 'ObjectListFilter' to use 'System.Text.Json' coercion Replaces custom value coercers with 'System.Text.Json'-based coercion in 'ObjectListFilter', supporting advanced scenarios like F# DUs and CLR enums via 'JsonSerializerOptions'. Updates 'ObjectListFilterLinqOptions' to accept 'JsonSerializerOptions'. Refactors 'TypeCoercion' module to use JSON serialization/deserialization for all type conversions. Updates filter application logic and expands the test suite with new files to cover a wide range of coercion scenarios. Updates documentation and usage examples accordingly. * Updateв schema, add type coercion guide, bug report, tools * Added bug report for InputObject array type mismatch with analysis and test cases * Added type coercion guide for ObjectListFilter with usage and API docs * Introduced format-changed-files.ps1 to batch-format changed F# files via Fantomas * Updated schema snapshots for relay-style connections and new scalars * Refactored field_aliases.fsx for relay-style friends connection * Optimized TypeCoercion.fs to use Utf8JsonWriter for value coercion * Added prompt template for automated PR/issue description generation * Rebase fix * Update filters to use `CurrentCulture` string comparison Updated all string comparison operations in `ObjectListFilter` and filter parsing logic to use `StringComparer.CurrentCulture` or `StringComparer.CurrentCultureIgnoreCase` instead of `Ordinal`/`OrdinalIgnoreCase`. Adjusted related test expectations to match. This ensures string-based filters now respect the current culture's case rules. * Rebase fixes * Removed unnecessary `ObjectListFilterValidationException` * Added test traits * AI review fixes * Fix ObjectListFilter IN coercion behavior and add converter/no-converter tests

* Enhanced `InputValue.OfObject` to handle `Guid` (as `StringValue "D"`), `IReadOnlyDictionary`/`IDictionary` (as `ObjectValue`), and improved F# union handling. * Added `GuidId` DU, wrapped scalar, and new `Guid`/`ValueObject` fields to test types, extended tests for filtering with `Guid` and custom value object scalars.

* Added `ObjectListFilterEmptyArrayTests.fs` with cases for Contains, Equals, Not Equals, and logical operators on empty/non-empty lists. Updated `.fsproj` to include the new file. * Extended `ObjectListFilterLinqGenerateTests.fs` to verify correct Cosmos SQL generation for list equality and length checks.

- Implemented comprehensive validation for interface field covariance, covering output type subtyping, argument compatibility, and field implementation checks. - Enhanced error messages with clearer formatting and context. - Updated validation logic for object, input object, union, and enum types to use interpolated strings. - Added `InterfaceCovarianceTests.fs` with extensive valid/invalid covariance scenarios. - Modernized `TypeValidationTests.fs` and expanded `UnionInterfaceTests.fs` for execution coverage.

…/file-upload/server (#558) Signed-off-by: dependabot[bot] <support@github.com>

#592) Signed-off-by: dependabot[bot] <support@github.com>

njlr · 2026-08-10T21:21:58Z

Can @copilot implement web sockets?

xperiandri · 2026-08-11T13:16:02Z

WebSockets are already implemented and packaged in ASP.NET Core project (as far as I remember)

njlr · 2026-08-11T13:26:19Z

WebSockets are already implemented and packaged in ASP.NET Core project (as far as I remember)

IIUIR Suave is outside of ASP.NET so this would need an implementation built on top of Suave socket. Not sure if this is too much to ask of Copilot but maybe it will get it?

…server (#586) Signed-off-by: dependabot[bot] <support@github.com>

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/1f4b9b83-930c-43b3-a8a5-8cf795269b9d Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Copilot AI assigned Copilot and xperiandri May 17, 2026

Copilot started work on behalf of xperiandri May 17, 2026 14:19 View session

Copilot AI linked an issue May 17, 2026 that may be closed by this pull request

FR: Suave package #566

Open

Copilot AI changed the title ~~[WIP] Add support for Suave integration similar to Giraffe/Oxpecker~~ Add Suave server integration package May 17, 2026

Copilot finished work on behalf of xperiandri May 17, 2026 14:44

Copilot AI requested a review from xperiandri May 17, 2026 14:44

Copilot started work on behalf of xperiandri May 17, 2026 18:07 View session

Copilot finished work on behalf of xperiandri May 17, 2026 18:09

Copilot AI and others added 6 commits May 18, 2026 12:04

Pin CI workflows and build script to .NET SDK 10.0.300 (#578)

075018b

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>

Pin CI workflows and build script to .NET SDK 10.0.301

19d11c3

Fixed Repo Assist incorrectly encoded characters

cc5fc0f

Bump lodash and babel-cli in /samples/graphiql-client (#584)

50b4569

Signed-off-by: dependabot[bot] <support@github.com>

xperiandri force-pushed the copilot/add-suave-integration-support branch from 46c8871 to 7be94f3 Compare June 13, 2026 18:24

Copilot AI and others added 6 commits June 13, 2026 22:24

Updated FSharp.TypeProviders.SDK to 8.10.0

e643b8d

fixup! Updated FSharp.TypeProviders.SDK to 8.10.0

bdd7297

High severity vulnerability fix: upgrade SQLitePCLRaw.lib.e_sqlite3…

15df50a

… to `3.53.3` (#588) Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Support case-insensitive comparison with ObjectListFilter (#582)

c1e8510

Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>

xperiandri force-pushed the dev branch from 382013c to a2c54ec Compare July 10, 2026 20:23

xperiandri added 4 commits August 10, 2026 00:54

Migrated to modern InternalsVisibleTo syntax

454a9e0

xperiandri added 4 commits August 10, 2026 00:54

Updated SDK to 10.0.302

060fd26

Updated Fantomas to 7.0.5

d971701

Updated FSDocs-Tools to 22.1.0

eada5c2

xperiandri force-pushed the dev branch from e256b0b to b9ce3ad Compare August 9, 2026 22:54

dependabot Bot added 2 commits August 10, 2026 01:10

Bump @protobufjs/utf8 from 1.1.0 to 1.1.1 in /samples/client-provider…

be74f88

…/file-upload/server (#558) Signed-off-by: dependabot[bot] <support@github.com>

Bump brace-expansion from 1.1.14 to 1.1.18 in /samples/graphiql-client (

c072f8e

#592) Signed-off-by: dependabot[bot] <support@github.com>

xperiandri force-pushed the copilot/add-suave-integration-support branch from 7be94f3 to f2196b0 Compare August 11, 2026 13:15

dependabot Bot and others added 4 commits August 11, 2026 15:27

Bump ws from 7.5.7 to 7.5.13 in /samples/client-provider/file-upload/…

7de55d4

…server (#586) Signed-off-by: dependabot[bot] <support@github.com>

Add Suave GraphQL server package

e1626b6

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/1f4b9b83-930c-43b3-a8a5-8cf795269b9d Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Polish Suave integration tests

d019699

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/1f4b9b83-930c-43b3-a8a5-8cf795269b9d Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Fix Suave handler XML docs

c4cfcc3

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Data.GraphQL/sessions/1f4b9b83-930c-43b3-a8a5-8cf795269b9d Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

xperiandri force-pushed the copilot/add-suave-integration-support branch from f2196b0 to c4cfcc3 Compare August 11, 2026 13:30

xperiandri force-pushed the dev branch from 414d542 to 182d1a1 Compare September 15, 2026 17:21

Navigation Menu

Add Suave server integration package - #567

Add Suave server integration package#567
xperiandri with Copilot wants to merge 26 commits into
devfrom
copilot/add-suave-integration-support

Copilot AI commented May 17, 2026 •

edited

Loading

Uh oh!

njlr commented May 17, 2026

Uh oh!

xperiandri commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

njlr commented Aug 10, 2026

Uh oh!

xperiandri commented Aug 11, 2026

Uh oh!

njlr commented Aug 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

njlr commented May 17, 2026

Uh oh!

xperiandri commented May 17, 2026

Uh oh!

Copilot AI commented May 17, 2026

Uh oh!

njlr commented Aug 10, 2026

Uh oh!

xperiandri commented Aug 11, 2026

Uh oh!

njlr commented Aug 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 17, 2026 •

edited

Loading