Conversation
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
Signed-off-by: HaoXuAI <sduxuhao@gmail.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6747 +/- ##
==========================================
- Coverage 47.18% 47.16% -0.03%
==========================================
Files 419 419
Lines 51964 52063 +99
Branches 7548 7564 +16
==========================================
+ Hits 24521 24554 +33
- Misses 25689 25757 +68
+ Partials 1754 1752 -2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
haoxu0
marked this pull request as ready for review
August 22, 2026 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
IcebergSourceWhy
Feast could read Iceberg sources, but local materialization could not persist results back to Iceberg. This adds a local-compute sink path so derived feature data can be maintained in Iceberg with idempotent upsert semantics.
Impact
Users can configure an
IcebergSourceas the effective batch source of a derived feature view and have local materialization upsert rows using mapped entity join keys plus the event timestamp. Existing online and offline materialization behavior remains unchanged.Validation
The broader repository unit run reached 2,469 passes. Three existing tests in unchanged on-demand transformation and SQLite paths still fail locally; the failures do not enter the Iceberg sink code. The pre-push
lint-pushwrapper was skipped because itsuv runresolves incompatible unrelatedciandflinkextras; the underlying lint and type checks were run directly and passed.