Conversation
OAuth2AuthorizationCodeBearer with auto_error=False
Member
|
@Eikentech, could you please review the PR description and make it shorter? |
Author
|
@YuriiMotov , I have updated the PR description, pls check. Thanks |
YuriiMotov
approved these changes
Jul 7, 2026
Member
There was a problem hiding this comment.
LGTM!
Implementation is as in test_security_oauth2_password_bearer_optional.py.
See the diff in details
Details
--- a/tests/test_security_oauth2_password_bearer_optional.py
+++ b/tests/test_security_oauth2_password_bearer_optional.py
@@ -1,11 +1,13 @@
from fastapi import FastAPI, Security
-from fastapi.security import OAuth2PasswordBearer
+from fastapi.security import OAuth2AuthorizationCodeBearer
from fastapi.testclient import TestClient
from inline_snapshot import snapshot
app = FastAPI()
-oauth2_scheme = OAuth2PasswordBearer(tokenUrl="/token", auto_error=False)
+oauth2_scheme = OAuth2AuthorizationCodeBearer(
+ authorizationUrl="authorize", tokenUrl="token", auto_error=False
+)
@app.get("/items/")
@@ -31,7 +33,7 @@ def test_token():
def test_incorrect_token():
- response = client.get("/items", headers={"Authorization": "Notexistent testtoken"})
+ response = client.get("/items", headers={"Authorization": "Non-existent testtoken"})
assert response.status_code == 200, response.text
assert response.json() == {"msg": "Create an account first"}
@@ -54,15 +56,21 @@ def test_openapi_schema():
},
"summary": "Read Items",
"operationId": "read_items_items__get",
- "security": [{"OAuth2PasswordBearer": []}],
+ "security": [{"OAuth2AuthorizationCodeBearer": []}],
}
}
},
"components": {
"securitySchemes": {
- "OAuth2PasswordBearer": {
+ "OAuth2AuthorizationCodeBearer": {
"type": "oauth2",
- "flows": {"password": {"scopes": {}, "tokenUrl": "/token"}},
+ "flows": {
+ "authorizationCode": {
+ "authorizationUrl": "authorize",
+ "tokenUrl": "token",
+ "scopes": {},
+ }
+ },
}
}
},
Author
|
@YuriiMotov , how this PR can be merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing optional-mode test (mirroring the existing
test_security_oauth2_password_bearer_optional.py) and removes the now-unnecessary# pragma: nocover.The fix
tests/test_security_oauth2_authorization_code_bearer_optional.py—auto_error=False, covering:Authorizationheader → returnsNone(handler returns the "create an account" message),Bearertoken → returns the token,Bearerscheme → returnsNone,# pragma: nocoveron thereturn Noneline, since the branch is now genuinely covered.Notes
This is a coverage-consistency fix, not a behaviour change —
fastapi/security/oauth2.pyruntime behaviour isunchanged; the PR only adds the missing test for an already-documented branch and drops the coverage-exclusion
pragma it was hidden behind.