Skip to content
This repository was archived by the owner on Jun 13, 2023. It is now read-only.

fix(pymongo): handle response collection error - #398

Merged
sagivr2020 merged 2 commits into
masterfrom
handle-response-collection-error-CS-164
Feb 14, 2022
Merged

sagivr2020 merged 2 commits into
masterfrom
handle-response-collection-error-CS-164

Conversation

@sagivr2020

Copy link
Copy Markdown
Member

No description provided.

@sagivr2020
sagivr2020 requested a review from a team as a code owner February 13, 2022 08:21
@sagivr2020
sagivr2020 requested a review from ophiryael February 13, 2022 08:21
@sagivr2020
sagivr2020 requested a review from maorlx February 13, 2022 08:21
Comment thread epsagon/events/pymongo.py
if self.resource['operation'] == 'find':
self.resource['metadata']['Results'] = \
list(response)
[response[i] for i in range(response.count())]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand the purpose of the change.
Can you attach an example of response object and type so I'll understand better what are you trying to achieve here? You can reach me on Slack if it would be easier.

@sagivr2020
sagivr2020 merged commit dffa938 into master Feb 14, 2022
@ranrib

ranrib commented Feb 14, 2022

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.77.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants