fix: reject bool/non-int port on URL construction - #1117
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
isinstance(True, int) is True, so port=True was stored and bytes(url) silently became host:1. Reject bool and other non-int ports with TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpcore.URL(..., port=True)stored a bool port. Becauseisinstance(True, int)is True,bytes(url)silently becamehost:1. Reject bool and other non-int ports withTypeError.Test plan
pytest tests/test_models.py::test_url_rejects_bool_port tests/test_models.py::test_url_rejects_non_int_portURL(scheme=b'http', host=b'h', port=True, target=b'/')raisesTypeError