Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev Caution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository: `* . (PR #XXXXX)`
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kayle
force-pushed
the
dev/kayle/public-pull-diagnostics
branch
from
September 21, 2026 17:12
2c066a8 to
f721517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F# hosts an independent language server in Visual Studio rather than using Roslyn's diagnostic handlers. The Visual Studio client prerequisite for public LSP pull diagnostics is already available, so this migrates the F# server to
textDocument/diagnosticwithout a dual private/public period.This removes only the private F# document diagnostic capability and
_vsrequest handler. The independent project-context provider remains registered. Public diagnostic capabilities use the Visual Studio-compatiblesyntaxidentifier, advertise inter-file dependencies, and intentionally do not advertise workspace diagnostics because F# does not implement a workspace diagnostic endpoint.Document pulls now return full or unchanged public reports using stable project-snapshot result IDs.