Remove trailing whitespace from src and vsintegration/src - #20393
Merged
Merged
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
Warning No PR link found in some release notes, please consider adding it.
|
This comment has been minimized.
This comment has been minimized.
xperiandri
force-pushed
the
remove-trailing-whitespace-src
branch
2 times, most recently
from
September 1, 2026 17:44
3cfbcca to
7431037
Compare
Contributor
Author
|
@T-Gro this is green too |
Member
|
We will want a git blame revs here as well , otherwise good to go |
Contributor
Author
|
Blame should be another PR. As hash will change |
xperiandri
force-pushed
the
remove-trailing-whitespace-src
branch
from
September 2, 2026 19:18
7431037 to
84d6770
Compare
Contributor
|
🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Compiler-Output
|
Strips trailing whitespace from F# sources under src/ and vsintegration/src, plus eng/Build.ps1. Trailing whitespace is preserved wherever it is semantically significant: lines whose end falls inside a multi-line string literal (STRING_TEXT) or inside an inactive `#if` region are left untouched. Those lines were classified with FSharp.Compiler.Tokenization.FSharpSourceTokenizer rather than a regex. Verified with the F# tokenizer: the string-literal token stream is byte-identical before and after for every file touched. Split out of dotnet#20355 so that each PR stays under the 3000-file limit enforced by the release-notes check. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
xperiandri
force-pushed
the
remove-trailing-whitespace-src
branch
from
September 4, 2026 16:12
84d6770 to
0cea648
Compare
Contributor
Author
|
@T-Gro all green, can be merged |
T-Gro
approved these changes
Sep 7, 2026
T-Gro
pushed a commit
that referenced
this pull request
Sep 7, 2026
The coreclr_release job was canceled after the 120-minute limit due to a flaky infrastructure timeout (memory pressure hanging an unrelated test assembly). The same job timed out on unrelated PRs #20235 and #20393 in the last 10 days. ComponentTests (all DIM/interface tests affected by this PR) passed fully, so the merge resolution is correct. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
added a commit
that referenced
this pull request
Sep 16, 2026
…lag (#20442) * Remove always-on DefaultInterfaceMemberConsumption language feature flag Delete the dead LanguageFeature.DefaultInterfaceMemberConsumption enum case, its features-map entry and GetFeatureString arm. Collapse every language-version gate to its always-on path. Decouple the target-runtime DIM check from the enum via InfoReader.IsRuntimeSupportForDefaultImplementationsOfInterfaces and a checkRuntimeSupportForDefaultInterfaceMembersAndRecover helper; the FSComp string is retained as the display name for the runtime FS3351 diagnostic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove featureDefaultInterfaceMemberConsumption FSComp string and regenerate xlf Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Re-trigger CI (flaky WindowsCompressedMetadata coreclr_release timeout) The coreclr_release job was canceled after the 120-minute limit due to a flaky infrastructure timeout (memory pressure hanging an unrelated test assembly). The same job timed out on unrelated PRs #20235 and #20393 in the last 10 days. ComponentTests (all DIM/interface tests affected by this PR) passed fully, so the merge resolution is correct. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Avoid per-call FSharpFunc closure in remapVal member-info remap (#20426) The Option.map mapping in remapValData was a partial application of remapMemberInfo, reified into a per-call FSharpFunc even though Option.map is inline. A syntactic lambda lets [<InlineIfLambda>] fire and lowers it to a direct call, removing one ~72 B closure allocation per copied Val. Co-authored-by: perf-bundle <perf@local> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 63a36ad7-0e8a-497d-9e96-7d7f03828b9a * Avoid per-call FSharpFunc closure in remapVal member-info remap (#20426) The Option.map mapping in remapValData was a partial application of remapMemberInfo, reified into a per-call FSharpFunc even though Option.map is inline. A syntactic lambda lets [<InlineIfLambda>] fire and lowers it to a direct call, removing one ~72 B closure allocation per copied Val. Co-authored-by: perf-bundle <perf@local> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 63a36ad7-0e8a-497d-9e96-7d7f03828b9a * Avoid per-call FSharpFunc closure in remapVal member-info remap (#20426) The Option.map mapping in remapValData was a partial application of remapMemberInfo, reified into a per-call FSharpFunc even though Option.map is inline. A syntactic lambda lets [<InlineIfLambda>] fire and lowers it to a direct call, removing one ~72 B closure allocation per copied Val. Co-authored-by: perf-bundle <perf@local> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 63a36ad7-0e8a-497d-9e96-7d7f03828b9a * Teach expert reviewers to check runtime representation preservation (#20511) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: perf-bundle <perf@local> Copilot-Session: 63a36ad7-0e8a-497d-9e96-7d7f03828b9a Copilot-Session: 616f5e9c-fc1c-4415-847e-4984261415c9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #20355 so that each PR stays under the 3000-file limit enforced by
check_release_notes(that check fails closed at >= 3000 changed files, before theNO_RELEASE_NOTESopt-out is even evaluated).This half covers
src/,vsintegration/srcandeng/Build.ps1(90 files). #20355 keeps the remaining 2932 files undertests/,vsintegration/tests,buildtools/anddocs/fcs-samples.No functional change
Trailing whitespace is preserved wherever it is semantically significant. Lines whose end falls inside a multi-line string literal (
STRING_TEXT) or inside an inactive#ifregion are left untouched. Those lines were classified withFSharp.Compiler.Tokenization.FSharpSourceTokenizerrather than a regex.Verification:
git diff -wover this branch reports no non-whitespace differences.Release notes
Entries added for the three protected paths touched here:
.FSharp.Core,.FSharp.Compiler.Serviceand.VisualStudio.src/Compiler/Facilities/LanguageFeatures.fsiis untouched, so no.Language/preview.mdentry is required.