add support for PidsLimit #734 - #764
Merged
KostyaSha merged 6 commits intoJan 17, 2017
Merged
Conversation
Contributor
|
Any news on this? It looks fine |
KostyaSha
reviewed
Jan 5, 2017
|
|
||
| InspectContainerResponse inspectContainerResponse = dockerClient.inspectContainerCmd(container.getId()).exec(); | ||
|
|
||
| assertEquals(inspectContainerResponse.getHostConfig().getPidsLimit(), hostConfig.getPidsLimit()); |
KostyaSha
reviewed
Jan 9, 2017
| @Override | ||
| public CreateContainerCmd withPidsLimit(Long pidsLimit) { | ||
| checkNotNull(pidsLimit, "pidsLimit was not specified"); | ||
| hostConfig.withPidsLimit(pidsLimit); |
Member
There was a problem hiding this comment.
the third PR... You can configure hostConfig directly without proxy calls from create object.
Member
There was a problem hiding this comment.
So even in testcase you create and configure hostConfig directly without calling proxy methods.
Member
|
And we end that it already supported and PR has only style formatting? |
added 3 commits
January 15, 2017 19:58
Member
|
Sorry, now looks good :) |
Contributor
Author
|
Should be fine, sorry for formatting problem :). |
KostyaSha
approved these changes
Jan 15, 2017
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
* add support for PidsLimit docker-java#734 * add support for PidsLimit docker-java#734 - using hamcrest in assertions * add support for PidsLimit docker-java#734 - remove proxing * add support for PidsLimit docker-java#734 - remove proxing * add support for PidsLimit docker-java#734 - formatting fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for #734
This change is