Fixes broken Docker documentation link - #735
Merged
Merged
Conversation
The official Docker documentation has moved around a bit and the link for how to configure the Docker Engine needed to be updated. The previous link pointed to a page that no longer exists.
KostyaSha
reviewed
Nov 2, 2016
| DOCKER_OPTS="-H tcp://127.0.0.1:2375 -H unix:///var/run/docker.sock" | ||
|
|
||
| More details about setting up Docker server can be found in official documentation: http://docs.docker.io/en/latest/use/basics/ | ||
| More details about setting up Docker Engine can be found in the official documentation: https://docs.docker.com/engine/admin/ |
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Yeah, but this page specifically talks about configuration and things like setting DOCKER_OPTS, which is what I think most people would want.
Current coverage is 71.13% (diff: 100%)@@ master #735 diff @@
==========================================
Files 303 303
Lines 6547 6547
Methods 0 0
Messages 0 0
Branches 592 592
==========================================
- Hits 4666 4657 -9
- Misses 1601 1607 +6
- Partials 280 283 +3
|
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
Fixes broken Docker documentation link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official Docker documentation has moved around a bit and the link for how to configure the Docker Engine needed to be updated. The previous link pointed to a page that no longer exists.
This change is