Fix for #643 - #648
Merged
KostyaSha merged 2 commits intoAug 1, 2016
Merged
Fix for #643#648
Conversation
.dockerignore rules handling refactored. A rule is translated to a regexp pattern and then a path is checked against it.
Member
|
Looks crazy :) |
Contributor
Author
|
@KostyaSha what exactly?) |
Member
|
Too much changes, will try read again bit later. |
Contributor
Author
|
@KostyaSha yeah, true. It's better to read |
Failing tests on Windows fixed: Windows file separator escaped.
Member
|
If something will fail, then it pure tests issue. Thanks for contribution! |
Member
|
Btw, would suggest look into docker-cli code and pick their algos :) |
Member
|
Checkstyle failed GoLangFileMatch length... |
Contributor
Author
|
@KostyaSha I will refactor and PR soon. |
Contributor
Author
|
Thanks for the good suggestion! I've almost guessed it right (https://github.com/docker/docker/blob/40044cb18fd4ff0ed13d8cdd41ec4dcecdac0703/pkg/fileutils/fileutils.go#L132) :) |
Member
|
And you can pick their test cases ;) |
panuse
pushed a commit
to TuKangTech/docker-java
that referenced
this pull request
Aug 20, 2017
* Fix for docker-java#643 .dockerignore rules handling refactored. A rule is translated to a regexp pattern and then a path is checked against it. * Fix for docker-java#643 Failing tests on Windows fixed: Windows file separator escaped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #643
.dockerignore rules handling refactored. A rule is translated to a regexp pattern and then a path is checked against it.
This change is