Upgraded jackson-jaxrs-json-provider dependency - #407
Merged
Merged
Conversation
Member
|
Please provide logs of what exactly problem do you see. |
Contributor
Author
|
Here is the stack trace docker-java depends on version 2.1.2, while spring-boot uses jackson 2.6.3. Since spring-boot-dependencies management pom does not include the dependency |
Member
|
I think docker-java can update dependency, but you can't satisfy everybody. Such update may break deps for somebody else, usually it should be done with using shaded artifacts #340 but it requires reorganise project to multi-module project. |
Contributor
Author
|
We have multi-module project. We shaded the artifact since it's the most common way to resolve that. Just thought that updating that would be a good idea, as that dependency does not remove the methods, just marks them as deprecated so it keeps backwards compatibility. Maybe I didn't perform the most extensive tests ever, but seems like upgrading the dependency is more compatible than keeping it that way. |
Member
|
Again, jenkins for example uses guava 11, but it doesn't mean that libraries should downgrade guava from 18 to 11. |
Contributor
Author
|
Of course not. As I said, we've shaded the artifact, which as you also pointed out is the most common way to do that. For me that's perfectly fine, but still seems like the most compatible and comfortable way, in case of this particular dependency, is upgrading the version. We found this issue when including docker-java and spring-boot-starter-web in the same pom.xml file, not when deploying. I can close the pull request if you want me too. I really do understand your point and your concerns. |
Member
|
@igracia i will keep up to @marcuslinke as i also like periodically update deps. Probably for 3.0 we can bump all deps and i will check in reference implementation. |
Member
|
Well, let's try. |
KostyaSha
added a commit
that referenced
this pull request
Dec 18, 2015
Upgraded jackson-jaxrs-json-provider dependency
Member
|
Mmm.. PR validator is again unavailable. Seems i need back my own. |
Contributor
Author
|
Cool, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a version problem when using spring-boot-starter-web 1.3.0, as it needs a later version than the one that the transitive dependency brings.