Skip to content

Use JDK Objects requireNonNull over Guava checkNotNull - #1981

Merged
eddumelendez merged 3 commits into
docker-java:mainfrom
belugabehr:require-non-null
Mar 30, 2023
Merged

eddumelendez merged 3 commits into
docker-java:mainfrom
belugabehr:require-non-null

Conversation

@belugabehr

Copy link
Copy Markdown
Contributor

Remove dependency on Google Guava library in favor of JDK APIs.

@Lewik Lewik mentioned this pull request Nov 18, 2022
@eddumelendez
eddumelendez self-requested a review November 30, 2022 15:44
@belugabehr

Copy link
Copy Markdown
Contributor Author

@eddumelendez Are you able to take a look at this?

Thanks.

@eddumelendez

Copy link
Copy Markdown
Member

@belugabehr the dependency was not dropped in order to avoid breaking changes?

@belugabehr

Copy link
Copy Markdown
Contributor Author

@eddumelendez This PR is not meant to remove all of Guava. This is just removing one piece. There will need to be additional work to remove it all.

@eddumelendez
eddumelendez requested a review from a team as a code owner March 9, 2023 00:04
@eddumelendez eddumelendez added this to the next milestone Mar 30, 2023
@eddumelendez
eddumelendez merged commit 97579e5 into docker-java:main Mar 30, 2023
@eddumelendez

Copy link
Copy Markdown
Member

Thanks for your contrbution, @belugabehr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants