Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

test: milvus len with disabled list like - #889

Merged
JohannesMessner merged 4 commits into
mainfrom
test-milvus-len
Dec 5, 2022
Merged

JohannesMessner merged 4 commits into
mainfrom
test-milvus-len

Conversation

@JohannesMessner

Copy link
Copy Markdown
Member

Goals:

A test for len of milvus if list_like=False, which is a special case for milvus len

Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
# Conflicts:
#	docarray/array/storage/milvus/seqlike.py
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
@codecov-commenter

codecov-commenter commented Dec 5, 2022

Copy link
Copy Markdown

Codecov Report

Base: 87.91% // Head: 88.15% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (11205af) compared to base (83d1bc5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   87.91%   88.15%   +0.23%     
==========================================
  Files         138      138              
  Lines        7148     7148              
==========================================
+ Hits         6284     6301      +17     
+ Misses        864      847      -17     
Flag Coverage Δ
docarray 88.15% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/qdrant/getsetdel.py 80.51% <0.00%> (+1.29%) ⬆️
docarray/array/storage/redis/getsetdel.py 97.14% <0.00%> (+1.42%) ⬆️
docarray/array/storage/milvus/getsetdel.py 98.52% <0.00%> (+1.47%) ⬆️
docarray/array/storage/elastic/getsetdel.py 100.00% <0.00%> (+1.58%) ⬆️
docarray/array/storage/annlite/getsetdel.py 100.00% <0.00%> (+2.43%) ⬆️
docarray/array/storage/weaviate/getsetdel.py 100.00% <0.00%> (+2.50%) ⬆️
docarray/document/mixins/porting.py 94.36% <0.00%> (+2.81%) ⬆️
docarray/array/storage/base/helper.py 90.56% <0.00%> (+3.77%) ⬆️
docarray/array/storage/milvus/seqlike.py 88.63% <0.00%> (+6.81%) ⬆️
docarray/array/storage/redis/seqlike.py 88.57% <0.00%> (+11.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JohannesMessner
JohannesMessner marked this pull request as ready for review December 5, 2022 10:57
@JohannesMessner
JohannesMessner merged commit 5ea0fc6 into main Dec 5, 2022
@JohannesMessner
JohannesMessner deleted the test-milvus-len branch December 5, 2022 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants