Fix: Correct FFTW version detection and NCCL build summary - #7995
Open
AsTonyshment wants to merge 1 commit into
Open
AsTonyshment wants to merge 1 commit into
AsTonyshment wants to merge 1 commit into
Conversation
AsTonyshment
requested review from
ZhouXY-PKU and
mohanchen
and
a lite review from Copilot
and removed request for
Copilot
September 20, 2026 15:49
Growl1234
reviewed
Sep 20, 2026
Comment on lines
+60
to
+69
| # FFTW has no version macro; use pkg-config metadata for the selected installation. | ||
| find_package(PkgConfig QUIET) | ||
| if(PKG_CONFIG_FOUND) | ||
| pkg_check_modules(PC_FFTW3 QUIET fftw3) | ||
| get_filename_component(_fftw3_library_dir "${FFTW3_LIBRARY}" DIRECTORY) | ||
| if(PC_FFTW3_FOUND AND PC_FFTW3_INCLUDEDIR STREQUAL FFTW3_INCLUDE_DIR | ||
| AND PC_FFTW3_LIBDIR STREQUAL _fftw3_library_dir) | ||
| set(FFTW3_VERSION "${PC_FFTW3_VERSION}") | ||
| endif() | ||
| endif() |
There was a problem hiding this comment.
Wouldn't it duplicate the fftw3 discovery practically?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
FFTW was reported as
version unknownbecause detection relied on a nonexistent header macro. NCCL parallel support was always reported asEnabled, even when disabled.Changes
version unknown.DisabledwhenENABLE_NCCL_PARALLEL_DEVICEis off.