fix: parent relative paths, and rework on the whole path extraction mechanics - #429
Merged
danmar merged 7 commits intoMay 30, 2025
Merged
Conversation
…echanics Include also another integration test function to check header in parent dir usage (was failing before)
Tal500
force-pushed
the
fix-parent-relative-path
branch
from
May 21, 2025 12:01
48cff47 to
4d4bab8
Compare
Tal500
marked this pull request as draft
May 21, 2025 16:43
danmar
reviewed
May 22, 2025
danmar
left a comment
Collaborator
There was a problem hiding this comment.
some comments. I didn't check it all carefully yet.
Tal500
marked this pull request as ready for review
May 22, 2025 10:24
danmar
reviewed
May 23, 2025
danmar
left a comment
Collaborator
There was a problem hiding this comment.
small question. partial review.
danmar
reviewed
May 30, 2025
Contributor
Author
|
I read your comments and reply in the code context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.