made check.h less heavy - #2633

The changes do not seem to have as much effect on the build times as I had hoped. But that's because a release build with the matchcompiler blows up some of the source files considerately causing the hot spots to be elsewhere.

Also the build times are quite erratic (in the CI and even locally) so it's not easy to compare them just by looking at the total time.

But that's because a release build with the matchcompiler blows up some of the source files considerately causing the hot spots to be elsewhere.

feel free to compare the debug build times when match compiler is not used. That is how I typically build.

The donate-cpu client might build cppcheck several times a day but I have the feeling it's a very low percentage of the time.

feel free to compare the debug build times when match compiler is not used. That is how I typically build.

The donate-cpu client might build cppcheck several times a day but I have the feeling it's a very low percentage of the time.

I am more concerned about the CI build times. The Appveyor times are ridiculous since the old Visual Studio compiler is just so damn slow. Just take a look at the last builds - it took more than a whole day for it to catch up with the current state.

I am more concerned about the CI build times. The Appveyor times are ridiculous since the old Visual Studio compiler is just so damn slow. Just take a look at the last builds - it took more than a whole day for it to catch up with the current state.

Yes that is a real problem. In general I think CI should finish in 10 or 20 minutes. We are far from that.

I am more concerned about the CI build times. The Appveyor times are ridiculous since the old Visual Studio compiler is just so damn slow. Just take a look at the last builds - it took more than a whole day for it to catch up with the current state.

Yes that is a real problem. In general I think CI should finish in 10 or 20 minutes. We are far from that.

Since appveyor is missing individual timing for the various steps it's hard to tell where to look. Also as seen in the past few days the timing is all over the place with builds ranging from 15 minutes to 45 minutes. I guess it depends on the overall load of the service.

But less includes and less CPU time spent is definitely better.

Feel free to merge if this is okay.

ok.. I think this is fine to merge also.. I just merge a CMake fix also and got a conflict.

Failure is caused by GitHub server issues.