Use per-instance caches in PythonParser - #2214
Merged
nedbat merged 1 commit intoJul 6, 2026
Merged
Conversation
first_line and exit_counts were cached with functools.lru_cache on the methods. A cache on a method is keyed by (self, args), so it pins the parser instances themselves. Caching on the instance instead makes reporting on a 99-file corpus 29% faster (1.78s to 1.27s, nearly all of it collector time) and drops live objects after the run from ~387k to ~17k. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XC1KLKyNuR5dA3YxAkxUC
Member
|
This is now released as part of coverage 7.15.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first_line and exit_counts were cached with functools.lru_cache on the methods. A cache on a method is keyed by (self, args), so it pins the parser instances themselves.
Caching on the instance instead makes reporting on a 99-file corpus 29% faster (1.78s to 1.27s, nearly all of it collector time) and drops live objects after the run from ~387k to ~17k.