Skip to content

test: fold near-identical test bodies into tables across eight packages #29463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibetitsmike merged 8 commits into from
Sep 17, 2026
Merged

test: fold near-identical test bodies into tables across eight packages #29463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
25b4ee6
test(coderd/templatebuilder): fold near-identical reject cases into a…
ibetitsmike Sep 17, 2026
b004de7
test(scripts/develop): fold near-identical devConfig validate cases i…
ibetitsmike Sep 17, 2026
ad33c87
test(agent/agentfiles): share the fuzzy edit request plumbing across …
ibetitsmike Sep 17, 2026
acdfc12
test(coderd/x/chatd/chatloop): fold near-identical batch runtime test…
ibetitsmike Sep 17, 2026
a764132
test(coderd/x/chatd/chatdebug): fold near-identical recording transpo…
ibetitsmike Sep 17, 2026
a6e35f2
test(enterprise/aibridgeproxyd): fold near-identical TestNew option c…
ibetitsmike Sep 17, 2026
95cc223
test(cli): fold near-identical sync golden subtests into a table
ibetitsmike Sep 17, 2026
d7c55d6
test(coderd/database/db2sdk): fold near-identical token metadata case…
ibetitsmike Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
377 changes: 117 additions & 260 deletions agent/agentfiles/files_test.go
View file
Open in desktop

Large diffs are not rendered by default.

469 changes: 143 additions & 326 deletions cli/sync_test.go
View file
Open in desktop

Large diffs are not rendered by default.

363 changes: 130 additions & 233 deletions coderd/database/db2sdk/db2sdk_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,239 +14,136 @@ import (
func TestAggregateTokenMetadata(t *testing.T) {
t.Parallel()

t.Run("empty_input", func(t *testing.T) {
t.Parallel()
result := aggregateTokenMetadata(nil)
require.Empty(t, result)
})

t.Run("sums_across_rows", func(t *testing.T) {
t.Parallel()
tokens := []database.AIBridgeTokenUsage{
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{"cache_read_tokens":100,"reasoning_tokens":50}`),
Valid: true,
},
},
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{"cache_read_tokens":200,"reasoning_tokens":75}`),
Valid: true,
},
},
}

result := aggregateTokenMetadata(tokens)
require.Equal(t, int64(300), result["cache_read_tokens"])
require.Equal(t, int64(125), result["reasoning_tokens"])
require.Len(t, result, 2)
})

t.Run("skips_null_and_invalid_metadata", func(t *testing.T) {
t.Parallel()
tokens := []database.AIBridgeTokenUsage{
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{Valid: false},
},
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: nil,
Valid: true,
},
},
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{"tokens":42}`),
Valid: true,
},
},
}

result := aggregateTokenMetadata(tokens)
require.Equal(t, int64(42), result["tokens"])
require.Len(t, result, 1)
})

t.Run("skips_non_integer_values", func(t *testing.T) {
t.Parallel()
tokens := []database.AIBridgeTokenUsage{
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
// Float values fail json.Number.Int64(), so they
// are silently dropped.
RawMessage: json.RawMessage(`{"good":10,"fractional":1.5}`),
Valid: true,
},
},
}

result := aggregateTokenMetadata(tokens)
require.Equal(t, int64(10), result["good"])
_, hasFractional := result["fractional"]
require.False(t, hasFractional)
})

t.Run("skips_malformed_json", func(t *testing.T) {
t.Parallel()
tokens := []database.AIBridgeTokenUsage{
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`not json`),
Valid: true,
},
},
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{"tokens":5}`),
Valid: true,
},
},
}

result := aggregateTokenMetadata(tokens)
// The malformed row is skipped, the valid one is counted.
require.Equal(t, int64(5), result["tokens"])
require.Len(t, result, 1)
})

t.Run("flattens_nested_objects", func(t *testing.T) {
t.Parallel()
tokens := []database.AIBridgeTokenUsage{
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{
"cache_read_tokens": 100,
"cache": {"creation_tokens": 40, "read_tokens": 60},
"reasoning_tokens": 50,
"tags": ["a", "b"]
}`),
Valid: true,
},
},
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{
"cache_read_tokens": 200,
"cache": {"creation_tokens": 10}
}`),
Valid: true,
},
},
}

result := aggregateTokenMetadata(tokens)
require.Equal(t, int64(300), result["cache_read_tokens"])
require.Equal(t, int64(50), result["reasoning_tokens"])
require.Equal(t, int64(50), result["cache.creation_tokens"])
require.Equal(t, int64(60), result["cache.read_tokens"])
// Arrays are skipped.
_, hasTags := result["tags"]
require.False(t, hasTags)
require.Len(t, result, 4)
})

t.Run("flattens_deeply_nested_objects", func(t *testing.T) {
t.Parallel()
tokens := []database.AIBridgeTokenUsage{
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{
"provider": {
"anthropic": {"cache_creation_tokens": 100, "cache_read_tokens": 200},
"openai": {"reasoning_tokens": 50}
},
"total": 500
}`),
Valid: true,
},
},
}

result := aggregateTokenMetadata(tokens)
require.Equal(t, int64(100), result["provider.anthropic.cache_creation_tokens"])
require.Equal(t, int64(200), result["provider.anthropic.cache_read_tokens"])
require.Equal(t, int64(50), result["provider.openai.reasoning_tokens"])
require.Equal(t, int64(500), result["total"])
require.Len(t, result, 4)
})

// Real-world provider metadata shapes from
// https://github.com/coder/aibridge/issues/150.
t.Run("aggregates_real_provider_metadata", func(t *testing.T) {
t.Parallel()
tokens := []database.AIBridgeTokenUsage{
{
// Anthropic-style: cache fields are top-level.
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{
"cache_creation_input_tokens": 0,
"cache_read_input_tokens": 23490
}`),
Valid: true,
},
},
{
// OpenAI-style: cache fields are nested inside
// input_tokens_details.
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{
"input_tokens_details": {"cached_tokens": 11904}
}`),
Valid: true,
},
},
{
// Second Anthropic row to verify summing.
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{
"cache_creation_input_tokens": 500,
"cache_read_input_tokens": 10000
}`),
Valid: true,
},
},
}

result := aggregateTokenMetadata(tokens)
// Anthropic fields are summed across two rows.
require.Equal(t, int64(500), result["cache_creation_input_tokens"])
require.Equal(t, int64(33490), result["cache_read_input_tokens"])
// OpenAI nested field is flattened with dot notation.
require.Equal(t, int64(11904), result["input_tokens_details.cached_tokens"])
require.Len(t, result, 3)
})

t.Run("skips_string_boolean_null_values", func(t *testing.T) {
t.Parallel()
tokens := []database.AIBridgeTokenUsage{
{
ID: uuid.New(),
Metadata: pqtype.NullRawMessage{
RawMessage: json.RawMessage(`{"tokens":10,"name":"test","enabled":true,"nothing":null}`),
Valid: true,
},
},
}

result := aggregateTokenMetadata(tokens)
require.Equal(t, int64(10), result["tokens"])
require.Len(t, result, 1)
})
cases := []struct {
name string
rows []pqtype.NullRawMessage
want map[string]any
}{
{
name: "empty_input",
want: map[string]any{},
},
{
name: "sums_across_rows",
rows: []pqtype.NullRawMessage{
{RawMessage: json.RawMessage(`{"cache_read_tokens":100,"reasoning_tokens":50}`), Valid: true},
{RawMessage: json.RawMessage(`{"cache_read_tokens":200,"reasoning_tokens":75}`), Valid: true},
},
want: map[string]any{
"cache_read_tokens": int64(300),
"reasoning_tokens": int64(125),
},
},
{
name: "skips_null_and_invalid_metadata",
rows: []pqtype.NullRawMessage{
{Valid: false},
{RawMessage: nil, Valid: true},
{RawMessage: json.RawMessage(`{"tokens":42}`), Valid: true},
},
want: map[string]any{"tokens": int64(42)},
},
{
// Float values fail json.Number.Int64(), so they are silently
// dropped.
name: "skips_non_integer_values",
rows: []pqtype.NullRawMessage{
{RawMessage: json.RawMessage(`{"good":10,"fractional":1.5}`), Valid: true},
},
want: map[string]any{"good": int64(10)},
},
{
// The malformed row is skipped, the valid one is counted.
name: "skips_malformed_json",
rows: []pqtype.NullRawMessage{
{RawMessage: json.RawMessage(`not json`), Valid: true},
{RawMessage: json.RawMessage(`{"tokens":5}`), Valid: true},
},
want: map[string]any{"tokens": int64(5)},
},
{
// Arrays are skipped.
name: "flattens_nested_objects",
rows: []pqtype.NullRawMessage{
{RawMessage: json.RawMessage(`{
"cache_read_tokens": 100,
"cache": {"creation_tokens": 40, "read_tokens": 60},
"reasoning_tokens": 50,
"tags": ["a", "b"]
}`), Valid: true},
{RawMessage: json.RawMessage(`{
"cache_read_tokens": 200,
"cache": {"creation_tokens": 10}
}`), Valid: true},
},
want: map[string]any{
"cache_read_tokens": int64(300),
"reasoning_tokens": int64(50),
"cache.creation_tokens": int64(50),
"cache.read_tokens": int64(60),
},
},
{
name: "flattens_deeply_nested_objects",
rows: []pqtype.NullRawMessage{
{RawMessage: json.RawMessage(`{
"provider": {
"anthropic": {"cache_creation_tokens": 100, "cache_read_tokens": 200},
"openai": {"reasoning_tokens": 50}
},
"total": 500
}`), Valid: true},
},
want: map[string]any{
"provider.anthropic.cache_creation_tokens": int64(100),
"provider.anthropic.cache_read_tokens": int64(200),
"provider.openai.reasoning_tokens": int64(50),
"total": int64(500),
},
},
{
// Real-world provider metadata shapes from
// https://github.com/coder/aibridge/issues/150: Anthropic keeps
// cache fields top-level and two rows sum, OpenAI nests them
// inside input_tokens_details and they flatten with dot notation.
name: "aggregates_real_provider_metadata",
rows: []pqtype.NullRawMessage{
{RawMessage: json.RawMessage(`{
"cache_creation_input_tokens": 0,
"cache_read_input_tokens": 23490
}`), Valid: true},
{RawMessage: json.RawMessage(`{
"input_tokens_details": {"cached_tokens": 11904}
}`), Valid: true},
{RawMessage: json.RawMessage(`{
"cache_creation_input_tokens": 500,
"cache_read_input_tokens": 10000
}`), Valid: true},
},
want: map[string]any{
"cache_creation_input_tokens": int64(500),
"cache_read_input_tokens": int64(33490),
"input_tokens_details.cached_tokens": int64(11904),
},
},
{
name: "skips_string_boolean_null_values",
rows: []pqtype.NullRawMessage{
{RawMessage: json.RawMessage(`{"tokens":10,"name":"test","enabled":true,"nothing":null}`), Valid: true},
},
want: map[string]any{"tokens": int64(10)},
},
}
for _, tc := range cases {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
tokens := make([]database.AIBridgeTokenUsage, 0, len(tc.rows))
for _, metadata := range tc.rows {
tokens = append(tokens, database.AIBridgeTokenUsage{ID: uuid.New(), Metadata: metadata})
}
require.Equal(t, tc.want, aggregateTokenMetadata(tokens))
})
}
}

func TestAggregateTokenUsage(t *testing.T) {
Expand Down
Loading
Loading