Conversation
Contributor
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
johnstcn
marked this pull request as ready for review
September 15, 2026 14:55
SasSwart
reviewed
Sep 16, 2026
SasSwart
left a comment
Contributor
There was a problem hiding this comment.
Thanks Cian et bots!
I've reviewed as much as I can in my timebox for today. I've focussed on the parts that I am familiar with. Perhaps another reviewer can focus on the agents side. Otherwise, I'll dig into that tomorrow.
| slog.F("agent_firewall_session_id", in.GetAgentFirewallSessionId()), slog.Error(err)) | ||
| } | ||
|
|
||
| workspaceID, err := interceptionAttribution(in) |
Contributor
There was a problem hiding this comment.
We should probably also log the workspace id as a field for calls on the other side of this DRPC connection as well. I don't think this PR has the LogRecorder yet, but we should remember to log it there as well.
pawbana
reviewed
Sep 16, 2026
ssncferreira
approved these changes
Sep 16, 2026
johnstcn
force-pushed
the
cian/aigov-637-include-workspace-level-attribution-to-ai-gateway-usage
branch
from
September 17, 2026 11:48
84167c8 to
6748664
Compare
pawbana
approved these changes
Sep 17, 2026
…bution-to-ai-gateway-usage
…-level-attribution-to-ai-gateway-usage' into cian/aigov-637-include-workspace-level-attribution-to-ai-gateway-usage
johnstcn
deleted the
cian/aigov-637-include-workspace-level-attribution-to-ai-gateway-usage
branch
September 18, 2026 14:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist lookup-free workspace attribution on AI Gateway interceptions for direct Codex and Claude Code traffic and delegated Coder Agents traffic.
Workspace IDs are derived from trusted workspace session-token names or persisted chat bindings, then stored per interception. Session details expose
interception_attributionsas a map keyed by interception ID; unknown attribution is represented by a null value. This avoids adding workspace database lookups to the request path.Closes AIGOV-637
Implementation plan
workspace_idto AI Gateway interceptions without a foreign key or index.workspace_idthrough the additive v1.3 gateway protocol and structured interception logs.interception_attributions, including tool-less interceptions and null values for unknown attribution.Generated by Coder Agents.