chore(site): enable role-has-required-aria-props oxlint rule - #29188
Merged
Merged
Conversation
Enable the jsx-a11y role-has-required-aria-props rule and fix the two resulting violations: wire aria-controls to the listbox on the model selector combobox trigger, and add aria-selected to autocomplete options.
DanielleMaywood
approved these changes
Sep 10, 2026
aqandrew
approved these changes
Sep 10, 2026
jeremyruppel
added this pull request to stack #29190
September 10, 2026 18:52
jeremyruppel
added a commit
that referenced
this pull request
Sep 10, 2026
Enables the `heading-has-content` oxlint rule (jsx-a11y/useHeadingContent), moving it out of the migration backlog and into the enforced a11y rules. Fixes the three heading wrapper components that spread props onto a bare heading element (`AlertTitle`, and the `SectionHeading`/`FilterGroupHeading` in the agents filter popover) so they destructure and render `children` explicitly, letting the rule verify the headings have content. > [!NOTE] > Stacked on top of #29188. Review and merge that PR first. > [!NOTE] > This PR was generated by Coder Agents on behalf of @jeremyruppel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the
role-has-required-aria-propsoxlint rule (jsx-a11y/useAriaPropsForRole), moving it out of the migration backlog and into the enforced a11y rules.Fixes the two resulting violations:
ModelSelector.tsx: wirearia-controlson the combobox trigger to auseId-generated id set on the listboxCommandList.Autocomplete.tsx: addaria-selectedto eachoption, driven by the highlighted index.Note
This PR was generated by Coder Agents on behalf of @jeremyruppel.