Skip to content

eng-2789: outcomes report reads both shapes of hackstack complete levels - #8472

Closed
codeluggage wants to merge 1 commit into
masterfrom
codeluggage/eng-2789-hs-single-student
Closed

eng-2789: outcomes report reads both shapes of hackstack complete levels#8472
codeluggage wants to merge 1 commit into
masterfrom
codeluggage/eng-2789-hs-single-student

Conversation

@codeluggage

@codeluggage codeluggage commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes ENG-2789 (again :))

A single student report still gets {python: N} for HackStack courses, so the course check from #8470 dropped the HackStack progress block. This covers both.

Summary by CodeRabbit

  • Bug Fixes
    • Improved course level calculations in outcomes reports.
    • Reports now correctly display completion levels for both classroom and individual student data formats.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c5c5aae7-8398-4228-85b5-49a57ddf78e3

📥 Commits

Reviewing files that changed from the base of the PR and between ee6539a and 7aef57e.

📒 Files selected for processing (1)
  • app/views/outcomes-report/OutcomesReportResultComponent.vue

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The outcomes report now uses numeric levels values directly. It calculates the maximum value for non-numeric level data. The course-type check was removed, and the related comment was updated.

Changes

Outcomes report formatting

Layer / File(s) Summary
Completion level calculation
app/views/outcomes-report/OutcomesReportResultComponent.vue		 completeLevels now uses numeric levels values directly. Non-numeric values continue through the object-value maximum calculation. The comment documents the classroom and single-student data shapes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: smallst

Merge Risk: ⚪ Minimal · up to 7aef5

The outcomes report supports both reported HackStack level shapes, so the change is ready to merge subject to normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the outcomes report change and the support for both HackStack completed-level data shapes. It matches the main change in the pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeluggage codeluggage mentioned this pull request Sep 18, 2026
Draft
@codeluggage
codeluggage deleted the codeluggage/eng-2789-hs-single-student branch September 18, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@codeluggage