Refactor to Facilitate Decoupling from Concrete Implementations of EventFormat - #539
Merged
Conversation
skepticoitusInteruptus
force-pushed
the
537-refactor-facilitate-decoupling-from-eventformat-impl
branch
from
March 23, 2023 15:27
8f82cdb to
02b5bd1
Compare
JemDay
suggested changes
Mar 23, 2023
JemDay
left a comment
Contributor
There was a problem hiding this comment.
It looks like you need to sign your 'git commit' to get the build to run.
I do like how this cleans up the dependencies, may need to tweak the documentation on the ContentType to make it clear it's only enumerating the types defined by the various CloudEvent formats.
Contributor
|
And it looks like you 'pushed' while I was commenting :-) |
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Contributor
Author
Yeah. I didn't intend to push so many commits. I tried (in vain) to rebase all but one of them away. But I ended up with even more than I started out with. I suck at |
pierDipi
reviewed
Mar 30, 2023
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
skepticoitusInteruptus
force-pushed
the
537-refactor-facilitate-decoupling-from-eventformat-impl
branch
from
April 1, 2023 17:30
53e6081 to
e1dbe9c
Compare
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
pierDipi
reviewed
Apr 11, 2023
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
alexec
pushed a commit
to alexec/sdk-java
that referenced
this pull request
Jun 6, 2023
…entFormat (cloudevents#539) - Introduce ContentType enum - Resolve formats by using the ContentType enum Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com> Signed-off-by: Alex Collins <alex_collins@intuit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #537
Example Usage of Proposed Refactor