Skip to content

Fix example in "Materialize an Extension" - #475

Merged
pierDipi merged 1 commit into
cloudevents:masterfrom
jolivaSan:patch-1
Sep 14, 2022
Merged

pierDipi merged 1 commit into
cloudevents:masterfrom
jolivaSan:patch-1

Conversation

@jolivaSan

Copy link
Copy Markdown
Contributor

Was using ExtensionParser instead ExtensionProvider

@pierDipi

Copy link
Copy Markdown
Member

Hi @jolivaSan, thanks for the fix!

can you fix the DCO as suggested on this page https://github.com/cloudevents/sdk-java/pull/475/checks?check_run_id=8225798690?

Was using `ExtensionParser` instead `ExtensionProvider`

Signed-off-by: Jorge Oliva <Jorge.OlivaFernandez@santander.co.uk>
@jolivaSan

Copy link
Copy Markdown
Contributor Author

@pierDipi Fixed!

@pierDipi pierDipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jolivaSan!

LGTM

@pierDipi
pierDipi merged commit 0dc1025 into cloudevents:master Sep 14, 2022
abutch3r pushed a commit to abutch3r/sdk-java that referenced this pull request Sep 22, 2022
Was using `ExtensionParser` instead `ExtensionProvider`

Signed-off-by: Jorge Oliva <Jorge.OlivaFernandez@santander.co.uk>
Signed-off-by: alex-butcher <21243172+abutch3r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants