Handles failed Keystone trust deletion during task finalization - #527
Merged
Merged
Conversation
claudiubelu
force-pushed
the
keystone-delete-trust
branch
from
September 18, 2026 17:54
0da47af to
8b6636b
Compare
_set_tasks_execution_status calls keystone.delete_trust() while finalizing a task / execution inside task_completed. If that call raises an exception, the exception propagates all the way back to the worker's RPC call, which then misinterprets its own successful task_completed() call as a failure and reports an error for a task that had already finished successfully. Log a warning and continue instead. Mocks out `coriolis.keystone.delete_trust` during integration tests, as we do not use Keystone for them.
claudiubelu
force-pushed
the
keystone-delete-trust
branch
from
September 19, 2026 10:17
8b6636b to
104985f
Compare
petrutlucian94
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_set_tasks_execution_statuscallskeystone.delete_trust()while finalizing a task / execution inside task_completed. If that call raises an exception, the exception propagates all the way back to the worker's RPC call, which then misinterprets its own successfultask_completed()call as a failure and reports an error for a task that had already finished successfully. Log a warning and continue instead.Mocks out
coriolis.keystone.delete_trustduring integration tests, as we do not use Keystone for them.