Skip to content

docs: refresh - #2098

Open
evenstensberg wants to merge 1 commit into
browserify:masterfrom
evenstensberg:docs-pass-1
Open

evenstensberg wants to merge 1 commit into
browserify:masterfrom
evenstensberg:docs-pass-1

Conversation

@evenstensberg

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread bin/advanced.txt

benefit: faster builds
cost: extra bytes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth having a separate single commit that purges all trailing whitespace in the entire repo?

Comment thread readme.markdown

![browserify!](./assets/logo.png)

# table of contents

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary, given that github automatically generates a TOC on every markdown file?

Comment thread readme.markdown
`PATH` everywhere instead, install it globally:

```
npm install -g browserify

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not advice people to install anything globally; the modern advice is to never install anything globally, and to use npx.

Comment thread readme.markdown
Comment on lines +956 to +959
# security

Please report security vulnerabilities as described in the
[security policy](security.md) rather than in a public issue.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, but seems redundant to me since https://github.com/browserify/browserify/security/policy already exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants