Skip to content

Do not pin the status an absent file returns #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aalhossary merged 1 commit into from
Sep 14, 2026
Merged

Do not pin the status an absent file returns #1154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions biojava-core/src/test/java/org/biojava/nbio/core/util/FileDownloadUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,19 @@ void testValidationFiles() throws IOException{
@Nested
class HttpStatus {

@Test
void notFoundThrowsAndLeavesNothingBehind() throws IOException {
// A path that is guaranteed absent from the wwPDB archive.
/**
* Which status an absent file comes back with is the server's business, and it
* changes: files.wwpdb.org moved behind Amazon S3 in September 2026, and S3
* answers a missing key with 403 rather than 404 when the caller cannot list
* the bucket. Pinning the code made this test fail on an upstream hosting
* change that broke nothing.
* <p>
* What must hold is the contract: an error status throws, and nothing is left
* on disk for it. {@link HttpStatusException#isNotFound()} is pinned separately
* below, without a network.
*/
@Test
void anAbsentFileThrowsAndLeavesNothingBehind() throws IOException {
URL missing = new URL("https://files.wwpdb.org/pub/pdb/data/structures/divided/mmCIF/zz/zzzz.cif.gz");
File dest = new File(System.getProperty("java.io.tmpdir"), "bj-missing.cif.gz");
File sizeFile = new File(dest.getParentFile(), dest.getName() + ".size");
Expand All @@ -228,14 +238,24 @@ void notFoundThrowsAndLeavesNothingBehind() throws IOException {

HttpStatusException e = assertThrows(HttpStatusException.class,
() -> FileDownloadUtils.downloadFile(missing, dest));
assertEquals(404, e.getStatusCode());
assertTrue(e.isNotFound());
assertFalse(dest.exists(), "a 404 body must never be written to the destination");
assertTrue(e.getStatusCode() >= 400,
"an absent file must report an error status, got " + e.getStatusCode());
assertFalse(dest.exists(), "an error body must never be written to the destination");

// ... and no validation metadata may be recorded for it either, or the
// cached error page would later pass validation.
FileDownloadUtils.createValidationFiles(missing, dest, null, FileDownloadUtils.Hash.UNKNOWN);
assertFalse(sizeFile.exists(), "no size file should be written for a 404 response");
assertFalse(sizeFile.exists(), "no size file should be written for an error response");
}

@Test
void isNotFoundCoversTheAbsentStatusesOnly() {
assertTrue(new HttpStatusException(404, "http://example.org/x", "Not Found").isNotFound());
assertTrue(new HttpStatusException(410, "http://example.org/x", "Gone").isNotFound());
// 403 is what an S3-backed archive returns for a missing key, but it is not a
// statement that the file does not exist, so it must not claim to be one
assertFalse(new HttpStatusException(403, "http://example.org/x", "Forbidden").isNotFound());
assertFalse(new HttpStatusException(500, "http://example.org/x", "Server Error").isNotFound());
}
}

Expand Down
Loading