Reject unsupported salt costs - #302
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Raise
BCrypt::Errors::InvalidCostwhenBCrypt::Engine.generate_saltreceives a cost aboveMAX_COST.On MRI, unsupported costs currently reach the native salt generator and return
nil; JRuby raises from its Java implementation. Validating the documented upper bound in the shared Ruby layer gives both engines a deliberate bcrypt error and prevents a nil salt from escaping the public method. This is the same boundary originally reported in #27.Reproduction
On bcrypt 3.1.22,
BCrypt::Engine.generate_salt(32)returnsnilon MRI. An external model checks costs 32, 99, and2**30; all now raiseBCrypt::Errors::InvalidCost, while the existing sub-minimum clamp andPassword.createupper-bound behavior remain unchanged.Verification
bundle exec rake compile spec: 39 examples, 0 failures on Ruby 4.0.6Compatibility
Valid costs are unchanged. The only behavior change is replacing an unusable nil result or engine-specific native exception for costs above 31 with the gem's documented invalid-cost error.