Use a monotonic clock for calibration - #301
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Measure
BCrypt::Engine.calibratewith Ruby's monotonic process clock instead of the adjustable wall clock.This keeps elapsed-time measurements stable when NTP, virtualization, or an administrator moves the system clock while calibration is running, and addresses the timing fragility discussed in #235 and #248.
Reproduction
An external focused model replaces
Time.nowwith a method that raises. The current implementation raises fromcalibrate; this branch returnsMIN_COSTfor a tiny time budget because calibration no longer consults wall time.Verification
bundle exec rake compile spec: 39 examples, 0 failures on Ruby 4.0.6Compatibility
No public API, cost selection algorithm, or supported platform changes.
Process.clock_gettime(Process::CLOCK_MONOTONIC)is available on the supported Ruby versions.