Conversation
… a simple Python function
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
pllim
reviewed
Sep 18, 2026
| @@ -0,0 +1 @@ | |||
| Replace regexp that can get bogged down in backtracking with simply Python function. | |||
Member
There was a problem hiding this comment.
Suggested change
| Replace regexp that can get bogged down in backtracking with simply Python function. | |
| Replace regexp that can get bogged down in backtracking with simple Python comparisons. |
Member
|
I will just have to trust you and the CI on this one. Just a small comment on change log verbiage. Would be nice if others well-versed in regex could have a look too. @jdavies-st , I remember you loved regex... |
Contributor
Loved is a bit strong. I do love https://regex101.com so I don't have to think too hard about them myself. 🧠 🚑 I'll have a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request replaces a regex with a simple Python function to avoid the regex loosing performance as it backtrachs through the capture groups.
AI disclosure
I used an LLM to help me understand the older regexp initially, but found that more traditional tools like regexp101.com actually helped me more.