Skip to content

cuda: honour the documented 64-byte d_name buffer in af_device_info #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
melonakos wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −5
Draft

cuda: honour the documented 64-byte d_name buffer in af_device_info #3717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
804de79
Honour documented d_name buffer size in CUDA af_device_info
melonakos Aug 29, 2026
d42cdcb
opencl: bound the device name sanitizer the same way
melonakos Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/backend/cuda/platform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,11 @@ void devprop(char *d_name, char *d_platform, char *d_toolkit, char *d_compute) {
const cudaDeviceProp &dev = getDeviceProp(getActiveDeviceId());

// Name
snprintf(d_name, 256, "%s", dev.name);
// af_device_info documents a recommended minimum size of 64 for d_name
// (see docs/details/device.dox, \defgroup device_func_prop), and the CPU
// and OpenCL backends honour it. Writing 256 bytes here overflowed
// conforming callers' buffers.
snprintf(d_name, 64, "%s", dev.name);

// Platform
string cudaRuntime = getCUDARuntimeVersion();
Expand All @@ -297,8 +301,10 @@ void devprop(char *d_name, char *d_platform, char *d_toolkit, char *d_compute) {
// Compute Version
snprintf(d_compute, 10, "%d.%d", dev.major, dev.minor);

// Sanitize input
for (int i = 0; i < 256; i++) {
// Sanitize input. The lookahead reads d_name[i + 1], so i must stop at
// 62 to stay inside the documented 64-byte buffer. Stopping at the
// terminator also avoids scanning past the end of a short device name.
for (int i = 0; i < 63 && d_name[i] != '\0'; i++) {
if (d_name[i] == ' ') {
if (d_name[i + 1] == 0 || d_name[i + 1] == ' ') {
d_name[i] = 0;
Expand Down
5 changes: 3 additions & 2 deletions src/backend/opencl/platform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,8 +493,9 @@ void devprop(char* d_name, char* d_platform, char* d_toolkit, char* d_compute) {
}
}

// Sanitize input
for (int i = 0; i < 31; i++) {
// Sanitize input. Stop at the terminator: the lookahead reads d_name[i + 1]
// and the loop must not run past the end of a short device name.
for (int i = 0; i < 63 && d_name[i] != '\0'; i++) {
if (d_name[i] == ' ') {
if (d_name[i + 1] == 0 || d_name[i + 1] == ' ') {
d_name[i] = 0;
Expand Down
Loading