Skip to content

3560 bug incorrect results when using the pow function with float16 arguments with cuda backend #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christophe-murphy merged 4 commits into from
Jan 30, 2025
+1 −5
Merged

3560 bug incorrect results when using the pow function with float16 arguments with cuda backend #3561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b92605d
Add cases for float16 arguments to atan2 and hypot functions
christophe-murphy Jun 3, 2024
5e1e336
Added test cases for half precision atan2 and hypot functions
christophe-murphy Jun 5, 2024
abd46ee
Fix for incorrect result when using the pow function with float16 arg…
christophe-murphy Jun 6, 2024
5a4d1b0
Merge branch 'master' into 3560-bug-incorrect-results-when-using-the-…
christophe-murphy Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/backend/cuda/kernel/jit.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,9 @@ typedef cuDoubleComplex cdouble;
#define __rem(lhs, rhs) ((lhs) % (rhs))
#define __mod(lhs, rhs) ((lhs) % (rhs))

#ifdef AF_WITH_FAST_MATH
#define __pow(lhs, rhs) \
static_cast<double>( \
pow(static_cast<double>(lhs), static_cast<double>(rhs)));
#else
#define __pow(lhs, rhs) \
__float2int_rn(powf(__int2float_rn((int)lhs), __int2float_rn((int)rhs)))
#endif
#define __powll(lhs, rhs) \
__double2ll_rn(pow(__ll2double_rn(lhs), __ll2double_rn(rhs)))
#define __powul(lhs, rhs) \
Expand Down
1 change: 1 addition & 0 deletions test/binary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ BINARY_TESTS_NEAR_FLOAT(pow)
BINARY_TESTS_NEAR_FLOAT(hypot)

BINARY_TESTS_NEAR_HALF(atan2)
BINARY_TESTS_NEAR_HALF(pow)
BINARY_TESTS_NEAR_HALF(hypot)

BINARY_TESTS_NEAR_DOUBLE(atan2)
Expand Down