Skip to content

Batch support for solve function in all backends - #1705

Merged
9prady9 merged 7 commits into
arrayfire:masterfrom
pavanky:linalg_batch
Jul 31, 2021
Merged

Batch support for solve function in all backends#1705
9prady9 merged 7 commits into
arrayfire:masterfrom
pavanky:linalg_batch

Conversation

@pavanky

@pavanky pavanky commented Jan 9, 2017 •
edited by 9prady9
Loading

Copy link
Copy Markdown
Member

@pavanky pavanky added this to the v3.5.0 milestone Jan 9, 2017
@mlloreda mlloreda modified the milestones: v3.5.1, v3.5.0 May 22, 2017
@pavanky pavanky modified the milestones: v3.5.1, v3.6.0 Jun 16, 2017
@pavanky
pavanky changed the base branch from devel to master August 23, 2017 15:22
@umar456 umar456 removed this from the v3.6.0 milestone Feb 27, 2018
@mchandra

mchandra commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

Hi, could this be merged into master? Would really help. Thanks.

@9prady9

9prady9 commented Apr 3, 2018

Copy link
Copy Markdown
Member

@pavanky How much more work is left for this feature to be complete ?

@mchandra

mchandra commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

I think this PR implements batch support for CUDA, not for OpenCL and the CPU backends (which don't have batch support implemented at the backend library level). I vote for merging as is -- with just CUDA batch support.

@WilliamTambellini

WilliamTambellini commented May 30, 2018

Copy link
Copy Markdown
Contributor

Watch up batched gemm in recent mkl :
#2146

@umar456 umar456 changed the title [WIP]: Batch support for linear algebra functions Batch support for linear algebra functions Jul 30, 2021
@umar456
umar456 force-pushed the linalg_batch branch 2 times, most recently from 4694594 to b85cf13 Compare July 30, 2021 03:46
9prady9
9prady9 requested changes Jul 30, 2021
View reviewed changes

@9prady9 9prady9 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also merge your solve related commits right after pavan's. The MKL option change is not needed, so that commit can be removed - please check the relevant change comment.

If the solve batch support change doesn't work without pinned memory commit, you can merge that as well into the commit that has all the solve batch support changes you added after pavan.

I am changing the title to reflect that this adds batch support for solve alone.

Comment thread test/solve_dense.cpp
Comment thread CMakeLists.txt
@9prady9 9prady9 changed the title Batch support for linear algebra functions Batch support for solve functions in all backends Jul 30, 2021
@9prady9 9prady9 changed the title Batch support for solve functions in all backends Batch support for solve function in all backends Jul 30, 2021
@9prady9 9prady9 added this to the 3.8.1 milestone Jul 30, 2021
@umar456
Add batch support for CPU and OpenCL solve. Add solver batch tests
1b0074f 
Add support for batching to the CPU and OpenCL backends. Uses
the MKL batching functions when MKL is enabled otherwise it
iterates over all of the slices if using LAPACK.
@umar456
Check symbols in MKL to enable solve batch functionality
1ee9b96 
We will first make sure that the getrf_batch_strided function is
available in MKL to determine if the batch functionality can be
used in ArrayFire. If it is available we will define the
AF_USE_MKL_BATCH function to enable the batching functions.
@9prady9
9prady9 merged commit b6680d5 into arrayfire:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umar456 umar456 umar456 left review comments
@9prady9 9prady9 9prady9 approved these changes

Assignees

No one assigned

Labels

improvement

Projects

None yet

Milestone

3.8.1

Development

Successfully merging this pull request may close these issues.

solve() inside gfor() for a large number of independent matrices

6 participants

@pavanky @mchandra @9prady9 @WilliamTambellini @umar456 @mlloreda