Guard push-ledger sweeper when appwritePushLedger is absent - #13772
Merged
Merged
Conversation
Co-authored-by: ArnabChatterjee20k <83803257+ArnabChatterjee20k@users.noreply.github.com>
Copilot
AI
changed the title
fix: guard push ledger sweeper when collection is missing
Guard push-ledger sweeper when Sep 19, 2026
appwritePushLedger is absent
Copilot created this pull request from a session on behalf of
ArnabChatterjee20k
September 19, 2026 17:27
View session
ArnabChatterjee20k
marked this pull request as ready for review
September 19, 2026 17:30
ArnabChatterjee20k
approved these changes
Sep 19, 2026
Contributor
|
loks0n
approved these changes
Sep 19, 2026
✨ Benchmark resultsComparing
Per-scenario breakdown & investigation detailsMetrics below reflect the current branch (after). Δ P95 compares against the base.
Top API waits (after)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deleteExpiredPushLedgercould attempt deletion against projects whereappwritePushLedgerdoes not exist, relying ononErrorhandling after entering delete flow. This change aligns the worker with the recommended guard-first pattern by short-circuiting before delete.What changed
Deletes::deleteExpiredPushLedger.appwritePushLedgeris missing, preserving existing behavior for projects where it exists.Why this matters
Code change (core)