Fix compute domain release after function and site deletion - #13691
Closed
HarshMN2345 wants to merge 18 commits into
Closed
HarshMN2345 wants to merge 18 commits into
HarshMN2345 wants to merge 18 commits into
Conversation
The worker test drives the queue and the database directly and never builds an HTTP client, so the response-format override read by the e2e Scope is meaningless to it. Dropping it also keeps the workflow_dispatch input out of this step's shell command. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MeytoiisEusFMCU44PDYav
✨ Benchmark resultsComparing
Per-scenario breakdown & investigation detailsMetrics below reflect the current branch (after). Δ P95 compares against the base.
Top API waits (after)
|
HarshMN2345
force-pushed
the
claude/deletes-preserve-recreated-domain
branch
from
September 18, 2026 09:06
75b6731 to
193ce56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a function or site currently leaves its proxy rules until the deletion worker runs. That delays domain reassignment and can make old domains appear on a resource created with the same public ID.
Remove owned rules before returning from resource deletion, matching the project, resource type, and internal resource identity. Keep the resource cleanup job queued before immediate rule removal, and defer provider/certificate cleanup using the removed rule snapshot. Routing also rejects stale or missing deployment resource identity with the existing resource-not-found response.
Fixes #8068.
This draft depends on safe deferred cleanup that preserves routing and provider configuration for a reassigned domain, and preserves any certificate still referenced by a live rule. It should be retargeted to main once that behavior is available there.
Validation:
83c958a019, CI Checks passed; Unit passed (1,195 tests, 6,002 assertions); General passed (42 tests, 240 assertions, 10 unrelated skips), including all four new delayed cleanup cases; Proxy passed (62 tests, 1,222 assertions, plus 12 internal tests with 105 assertions). Functions, Sites, schedules, and the other affected API suites also passed.AvatarsTest::testGetImageFromURLreceives JSON instead of an image from its external-image request; AvatarstestGetImagefails in all three scopes with HTTP 404 instead of 200 forhttps://appwrite.io/images/open-graph/website.avif; S3 setup fails before tests because the runner cannot pullminio/minio. The draft status is retained.