Fix socket forwarding hangs and shared I/O stalls - #933
Merged
Merged
Conversation
realrajaryan
force-pushed
the
fix-socket-fwd-hang
branch
4 times, most recently
from
September 18, 2026 19:04
f24636d to
a6d9ab2
Compare
dkovba
reviewed
Sep 21, 2026
realrajaryan
force-pushed
the
fix-socket-fwd-hang
branch
from
September 23, 2026 00:02
a6d9ab2 to
02ddd03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the SSH-agent forwarding hangs and terminal/exec stalls reported in apple/container#2247. The relay now registers both ends before forwarding starts and resumes blocked writes when the destination is ready, allowing other work on the shared I/O loop to continue. When connections close, buffered data is drained before EOF and stale events are discarded as file descriptors are reused. On the host, failed socket connections are closed individually so the listener keeps accepting new clients.