Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2606 +/- ##
============================================
+ Coverage 71.38% 71.81% +0.42%
- Complexity 50619 50655 +36
============================================
Files 1638 2075 +437
Lines 196872 222176 +25304
Branches 38253 38264 +11
============================================
+ Hits 140534 159549 +19015
- Misses 45283 51581 +6298
+ Partials 11055 11046 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…write rule to split off permanent reads into a dedicated statement block such that we can use the sparsity information about this data in the main statment block feat(main/hops/rewrite/ProgramRewriter.java): add the new rewrite rule to the set of applied rewriters
…add unit test for splitting the statement block due to unknown sparsity of permanent read feat(test/scripts/functions/rewrite/RewriteSplitDagUnknownNnz.dml): add dml script for unit test
…f sparsity rewrites are enabled (pointless otherwise)
… apply formatting remove unused import
…): print the sparsity information together with the individual matrix dimensions when logging the parenthesization of a matrix multiplication chain
ywcb00
force-pushed
the
feat/recompile/sparsity/read
branch
from
September 10, 2026 07:08
90e8e4c to
c802b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds the rewriting functionality to split a permanent read operation into a separate, preceding statement block if the meta data of the read object does not provide information about its number of non-zeros beforehand. By performing the read separately, the sparsity information can already be leveraged when recompiling the main program block.
The PR also adds a flag to disable and enable this new feature (disabled by default) as well as unit tests to cover the functionality.
All the best,
David