GH-3039: Keep protobuf oneof fields optional when unwrapping wrappers - #3799
Open
sankalpsthakur wants to merge 1 commit into
Open
sankalpsthakur wants to merge 1 commit into
sankalpsthakur wants to merge 1 commit into
Conversation
…appers Unwrap mode was forcing every primitive to REQUIRED, which is invalid for oneof members because only one alternative can be written. Keep oneof fields optional and add schema plus validated round-trip coverage. Co-authored-by: Sankalp Thakur <sankalpsthakur@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When
parquet.proto.unwrapProtoWrappersis enabled,ProtoSchemaConvertermarks every primitive fieldREQUIRED. That is invalid for protobufoneofmembers: at most one alternative can be written, so the other members are absent. Write validation then fails, and even without validation the schema claims fields a legal oneof record cannot populate.Fixes #3039.
What changes are included in this PR?
oneofmembers optional when converting protobuf schemas in unwrap mode.REQUIREDin unwrap mode, matching existing documented behavior.OneOfTestMessage.Are these changes tested?
Yes.
parquet-protobufmodule tests, including:ProtoSchemaConverterTest.testProto3ConvertOneOfProtoSchemaConverterTest.testProto3ConvertOneOfUnwrappedProtoWriteSupportTest.testMessageOneOfUnwrappedRoundTrip(unwrap +withValidation(true))Are there any user-facing changes?
Yes. Unwrap-mode schemas for protobuf
oneofprimitives change fromrequiredtooptional. Newly written files are valid; previously written unwrap+oneof files withrequiredmembers remain readable.Contributor: Sankalp Thakur (
sankalpsthakur). Apache ICLA note: this contribution is offered under the Apache License 2.0; please confirm ICLA status against ASF records if required for merge.Closes #3039