Port the IT scripts from BeanShell to Groovy - #332
Merged
Merged
Conversation
BeanShell is being retired across Maven (apache/maven#13207); the scripts keep the same checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the 14 BeanShell IT scripts under
src/itto Groovy, keeping the same checks. Four were already valid Groovy; ten hadString[] x = { … }initialisers (now list literals) andjar-includes-excludesredeclared four typed locals in one scope, which Groovy rejects (the second occurrences are plain assignments now). The rename is a separate commit so the port reads as a diff. Part of apache/maven#13207.Verified:
mvn verify -Prun-its -Dinvoker.test=<all 14 ITs>with Maven 4.0.0-rc-6 → Passed: 14, Failed: 0.