Conversation
PAGE_LOCKED_TIMES is "Page [{}] had been locked {} times.", but only the
write hold count was passed to the logger. SLF4J filled the first
placeholder with the count and printed the second one literally, so the
warning reported the hold count as the page index and never showed the
count itself.
Pass page.getPageIndex() as the first argument, matching the neighbouring
REENTRANT_WRITE_LOCKS_DETAIL call in the same method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PAGE_LOCKED_TIMES is "Page [{}] had been locked {} times.", but only the hold
count was passed. SLF4J put the count in the page slot and printed the second
placeholder literally, so the warning showed the wrong number and never told
you which page it was.
Pass page.getPageIndex() first, same as the REENTRANT_WRITE_LOCKS_DETAIL call
a few lines below.