Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #25469 +/- ##
========================================
Coverage 82.34% 82.35%
========================================
Files 1137 1137
Lines 432713 432975 +262
Branches 432713 432975 +262
========================================
+ Hits 356338 356577 +239
- Misses 54842 54850 +8
- Partials 21533 21548 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yashrb24
marked this pull request as ready for review
September 18, 2026 11:22
yashrb24
commented
Sep 18, 2026
Comment on lines
+156
to
+166
| fn struct_field_mapping( | ||
| &self, | ||
| literal_args: &[Option<ScalarValue>], | ||
| ) -> Option<StructFieldMapping> { | ||
| Some(StructFieldMapping { | ||
| field_accessor: Arc::new(ScalarUDF::from(GetFieldFunc::new())), | ||
| fields: (0..literal_args.len()) | ||
| .map(|i| (vec![ScalarValue::Utf8(Some(format!("c{i}")))], i)) | ||
| .collect(), | ||
| }) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
StructFunc from datafusion-functions crate already provides support for this, but instead of adding another dependency I thought it might be a better idea to have it defined separately here instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #25463
Rationale for this change
Multi-column joins can produce filters such as:
DataFusion can evaluate this filter on individual rows, but it does not extract the allowed values for each column. This prevents bloom filters from using those values to skip row groups.
What changes are included in this PR?
a IN (1, 2)andb IN (10, 20).(1, 20)are still rejected.This will only enable bloom filter pruning for row groups.
What is the testing strategy for this PR?
Added tests for value extraction, NULLs, dictionary values, and reordered named fields.
Are there any user-facing changes?
Queries with supported tuple IN filters, including dynamic filters from multi-column joins, may read fewer row groups when Bloom filters are available. Query results remain unchanged.