refactor(theme): align hue direction with mode - #49820
Merged
Merged
Conversation
Order light-mode hue scales from dark at 100 to light at 900 while keeping dark-mode scales ordered from light at 100 to dark at 900. Reverse light references and V1 migration anchors so resolved colors remain unchanged. With 100 now the foreground end in both modes, remove the mode-aware raise() helper and use decrease() directly. Fixed-step syntax, categorical, terminal, and accent consumers now share the same indices across modes where their colors match.
Contributor
Author
|
Visual verification complete: 40/40 states identical across |
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Give hue steps a mode-relative contrast direction:
This makes
100the foreground end and900the background end in both modes.Changes
light: 300,dark: 200).raise(): with both mode scales sharing the foreground direction, it is exactlydecrease(); callers now usedecrease()directly.resolveTheme()andgenerateSyntax().Verification before PR
packages/theme: typecheck and 6 tests passpackages/tui: typecheck and focused theme/TUI suites pass (85 tests before the final restore; targeted hue/migration suite passes after)The first full snapshot run captured all 20 dark/light baseline states but hit a git-index conflict while restoring the stash before the after capture. The change was restored manually and committed safely. I will rerun the visual comparison against this committed PR branch.