perf(@angular/build): only reset Sass worker pool caches when stylesheet files change - #34117
Open
alan-agius4 wants to merge 1 commit into
Open
alan-agius4 wants to merge 1 commit into
alan-agius4 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request optimizes the build process by conditionally resetting the Sass worker pool caches only when stylesheet changes (Sass, SCSS, or CSS) are detected. However, the current implementation attempts to call the ".some()" method on "changes.all", which is a Set and will result in a runtime TypeError. It is recommended to use a "for...of" loop to iterate over the set and check for stylesheet changes, allowing for an early exit.
Open
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid resetting the Sass worker pool caches during watch rebuilds if no stylesheet files (
.scss,.sass,.css) were modified.