Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
The DevTools message bus implementations use
anycasts when invoking event callbacks because the relationship between a callback and its argument tuple is not preserved at the invocation site.PriorityAwareMessageBusalso usesanyfor forwarded callback arguments.What is the new behavior?
MessageBusnow provides a typedinvokeCallbackhelper that preserves the callback parameter tuple throughParameters<F>.The DevTools message bus implementations use this helper instead of casting callbacks to
any.PriorityAwareMessageBusalso types forwarded arguments asParameters<Events[E]>, andChromeMessageBuskeeps the message topic tied to the same generic event key when invoking a callback.This removes the unsafe callback casts while preserving the existing runtime behavior and public API.
Does this PR introduce a breaking change?