fix(compiler): expand security schema for URL sinks#68409
Open
izzettin-ahmet wants to merge 2 commits intoangular:mainfrom
Open
fix(compiler): expand security schema for URL sinks#68409izzettin-ahmet wants to merge 2 commits intoangular:mainfrom
izzettin-ahmet wants to merge 2 commits intoangular:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, several element-attribute pairs that function as URL or Resource URL sinks are not registered in the DomSanitizer security schema (SECURITY_SCHEMA). This means that values bound to these properties (e.g., meta[content], table[background], or svg:use[href]) are not automatically validated against Angular's security contexts at compile time.
Issue Number: N/A (Proactive security hardening)
What is the new behavior?
This PR expands the dom_security_schema.ts to include these missing sinks.
meta|content and background attributes are now registered under SecurityContext.URL.
use|href and use|xlink:href are now registered under SecurityContext.RESOURCE_URL.
This ensures the framework provides "Secure by Default" protection for these attributes by generating the appropriate ɵɵsanitizeUrl or ɵɵsanitizeResourceUrl instructions.
Does this PR introduce a breaking change?
Other information
This update aligns the Angular security schema with modern browser behaviors and MDN standards for URL-handling attributes. By registering these sinks, we provide a consistent defense-in-depth posture across all valid HTML and SVG resource-loading paths.