Skip to content

docs: use contentChildren() in component harness example#68385

Open
erkamyaman wants to merge 1 commit intoangular:mainfrom
erkamyaman:docs-adev-harness-use-content-children-signal
Open

docs: use contentChildren() in component harness example#68385
erkamyaman wants to merge 1 commit intoangular:mainfrom
erkamyaman:docs-adev-harness-use-content-children-signal

Conversation

@erkamyaman
Copy link
Copy Markdown
Contributor

The example already uses the signal-based input() but still declares items with the @ContentChildren decorator. Convert to the signal-based contentChildren() query for consistency.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The MyMenu example in the component harness guide uses the signal-based input() but declares its content query with the decorator-based @ContentChildren, mixing the two styles in the same example

Issue Number: N/A

What is the new behavior?

The query now uses the signal-based contentChildren() function (items = contentChildren(MyMenuItem)), matching the modern style of the surrounding input() call.

Does this PR introduce a breaking change?

  • Yes
  • No

The example already uses the signal-based input() but still declares
items with the @ContentChildren decorator. Convert to the signal-based
contentChildren() query for consistency.
@pullapprove pullapprove Bot requested a review from alan-agius4 April 26, 2026 13:12
@angular-robot angular-robot Bot added the area: docs Related to the documentation label Apr 26, 2026
@ngbot ngbot Bot added this to the Backlog milestone Apr 26, 2026
@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 26, 2026
@JeanMeche JeanMeche removed the request for review from alan-agius4 April 26, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants