docs: use contentChildren() in component harness example#68385
Open
erkamyaman wants to merge 1 commit intoangular:mainfrom
Open
docs: use contentChildren() in component harness example#68385erkamyaman wants to merge 1 commit intoangular:mainfrom
erkamyaman wants to merge 1 commit intoangular:mainfrom
Conversation
The example already uses the signal-based input() but still declares items with the @ContentChildren decorator. Convert to the signal-based contentChildren() query for consistency.
JeanMeche
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example already uses the signal-based input() but still declares items with the
@ContentChildrendecorator. Convert to the signal-based contentChildren() query for consistency.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
MyMenuexample in the component harness guide uses the signal-basedinput()but declares its content query with the decorator-based@ContentChildren, mixing the two styles in the same exampleIssue Number: N/A
What is the new behavior?
The query now uses the signal-based
contentChildren()function (items = contentChildren(MyMenuItem)), matching the modern style of the surroundinginput()call.Does this PR introduce a breaking change?