docs: use inject() in @Self example in hierarchical DI guide#68383
Open
erkamyaman wants to merge 1 commit intoangular:mainfrom
Open
docs: use inject() in @Self example in hierarchical DI guide#68383erkamyaman wants to merge 1 commit intoangular:mainfrom
erkamyaman wants to merge 1 commit intoangular:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The surrounding @SkipSelf and @host examples already use inject(), and the section intro recommends it. Align the @self example to match.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
@Self()example in the "Resolution modifiers" section of the hierarchical DI guide uses constructor-based injection (constructor(@Self() public flower: FlowerService) {}), while the section intro recommends using each modifier in theinject()configuration, and the surrounding@SkipSelfand@Hostexamples (and the other@Selfexample in the same section) already use theinject()form.Issue Number: N/A
What is the new behavior?
The
@Self()example now usesinject(FlowerService, {self: true}), matching the surrounding examples and the section's stated guidance. The dedicated "Modifiers with constructor injection" subsection still documents the legacy decorator-based form.Does this PR introduce a breaking change?
Other information